From:	CSBVAX::CSBVAX::MRGATE::"SMTP::CRVAX.SRI.COM::RELAY-INFO-VAX" 23-NOV-1988 02:28
To:	MRGATE::"ARISIA::EVERHART"
Subj:	VAXCIO bug (and notification of BSD curses for VMS).


Received: From KL.SRI.COM by CRVAX.SRI.COM with TCP; Tue, 22 NOV 88 22:15:43 PDT
Received: from ucbvax.Berkeley.EDU by KL.SRI.COM with TCP; Tue, 22 Nov 88 21:52:52 PST
Received: by ucbvax.Berkeley.EDU (5.59/1.31)
	id AA07061; Tue, 22 Nov 88 21:00:21 PST
Received: from USENET by ucbvax.Berkeley.EDU with netnews
	for info-vax@kl.sri.com (info-vax@kl.sri.com)
	(contact usenet@ucbvax.Berkeley.EDU if you have questions)
Date: 23 Nov 88 00:15:35 GMT
From: tektronix!gvgpsa!gvgpvd!tony@ucbvax.Berkeley.EDU  (Tony Ivanov)
Organization: Grass Valley Group, Inc., Grass Valley, CA
Subject: VAXCIO bug (and notification of BSD curses for VMS).
Message-Id: <912@gvgpvd.GVG.TEK.COM>
Sender: info-vax-request@kl.sri.com
To: info-vax@kl.sri.com

I just discovered a bug in the VAXCIO code I just sent out.  It
figures, though, since It's been working fine for two years now
and I've finally just distributed it :-S.  Anyway, here is the fix:

File name:	support.c
Module name:	gvg$do_qio_write
Source lines:	377, 378
Replace:
		if ((CNT <= 1) ||
		    ((ptr == &(buff[nbytes-1])) && (FLAG&_IONBF != 0)) ||
		    (FLAG&_IONBF==0 && OFLAG(ONLCR) && *PTR=='\n') )
with:
		if ((CNT <= 1) ||
		    ((ptr == &(buff[nbytes-1])) && ((FLAG&_IONBF) != 0)) ||
		    ((FLAG&_IONBF)==0 && OFLAG(ONLCR) && *PTR=='\n') )

Notice the parens around "FLAG&_IONBF" conditionals.  Damn precedence rules!

As you can see, this change would not affect normal operation, only if you
decided to reset the _IONBF flag (and only in certain cases) by hand.
Occasionally, the program would not buffer the output and you would get
single character (direct) I/O which is tediously slow!


As a side note: I have have compiled a copy of 4.2 curses for VMS that sits
on top of VAXCIO.  Since the source is copyright protected, I can only dis-
tribute the object library.  For those of you interested, please give me a
call (voice lines) to arrange a method of delivery.

			--Tony Ivanov
			tony@gvgpvd.GVG.TEK.COM
			...ucbvax!tektronix!gvgpsa!gvgpvd!tony
			(916)478-3238
-- 
/* My opinions...             *  Tony Ivanov   MS-4B       *  ...ucbvax!   */
/* shared by my company?!...  *  Grass Valley Group, Inc.  *  tektronix!   */
/* you've got to be kidding!  *  P.O. Box 1114             *  gvgpsa!      */
/* "tony@gvgpvd.GVG.TEK.COM"  *  Grass Valley, CA  95945   *  gvgpvd!tony  */