From:	CSBVAX::MRGATE!@KL.SRI.Com,@wiscvm.wisc.edu:JOE@FHCRCVAX.BITNET@SMTP 26-SEP-1987 00:12
To:	EVERHART
Subj:	INDEX bugs.. (anyone have LINT?)

Received: from wiscvm.wisc.edu by KL.SRI.COM with TCP; Fri 25 Sep 87 09:42:55-PDT
Received: from FHCRCVAX.BITNET by wiscvm.wisc.edu ; Fri, 25 Sep 87 11:42:13 CDT
Date: Fri, 25 Sep 87 09:42 PDT
From: Joe Meadows <JOE%FHCRCVAX.BITNET@wiscvm.wisc.edu>
Subject: INDEX bugs.. (anyone have LINT?)
To: info-vax@kl.sri.COM
X-VMS-To: IN%"info-vax@kl.sri.com"

  Hello, after noticing and fixing a problem last night with GET_HEADER.C,
I checked all my other FID related declarations, and noticed that most
of them are declared as "short int" rather than "unsigned short int",
except in the header files, which are all correctly unsigned..
You should modify DISPLAY.C, SEARCH.C, FID.C, and INDEX.C (as well as
GET_HEADER.C), searching for all declarations of variables with the
name FID in them (i.e. fid[3], nxtfid[3]), and changing them from
things like "short int fid[3]" to "unsigned short int fid[3]".

  I sure wish I had LINT, which I assume could warn me about such quirks
as mixing a signed with an unsigned.. Actually, I think it's crazy that
LINT is a program separate from the compiler, I'd rather have compiler
switches (like /WARN=STUPID_DATA_TYPE_MIXING).. Anyway, if anyone does
have LINT, I'd love to see the output of a pass through all of the INDEX
routines, I imagine there's all kinds of subtle (and not so subtle) things
that it might catch for me..

  Cheers.
  Joe Meadows Jr.
  VAX/VMS System Manager / guru in training
  Fred Hutchinson Cancer Research Center
  1124 Columbia St.
  Seattle Wa. 98104
     bitnet - JOE@FHCRCVAX
     arpa   - JOE%FHCRCVAX.BITNET@WISCVM.WISC.EDU
     voice  - (206) 467-4970
